Issue 344073002: Merge 278153 "Backoff: Respect maximum delay in face of float ov..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344073002: Merge 278153 "Backoff: Respect maximum delay in face of float ov..." (Closed)

Created:
6 years, 6 months ago by Nicolas Zea

Modified:
6 years, 6 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

Merge 278153 "Backoff: Respect maximum delay in face of float ov..." > Backoff: Respect maximum delay in face of float overflow > > Due to the 11 bit limitations for exponents in double precision, it's possible > to overflow when calculating the backoff amount. Check for this overflow and > drop back to the max backoff delay if necessary. > > BUG=373181 > R=cbentzel@chromium.org > > Review URL: https://codereview.chromium.org/337803004 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278471

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -10 lines)			Patch
	M	net/base/backoff_entry.cc	View		2 chunks	+29 lines, -10 lines	0 comments	Download
	M	net/base/backoff_entry_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Nicolas Zea

6 years, 6 months ago (2014-06-19 20:23:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r278471 (tree was closed).