Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 344063004: Subzero: Add 'not' to the list of LLVM commands in lit.cfg. (Closed)

Created:
6 years, 6 months ago by Jim Stichnoth
Modified:
6 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Add 'not' to the list of LLVM commands in lit.cfg. Without this being in the command substitutions list, lit will rely on the 'not' command being in $PATH. The substitution code is adapted from llvm/test/lit.cfg to add word-break regexps to the list. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cc27a53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tests_lit/lit.cfg View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 6 months ago (2014-06-26 20:19:07 UTC) #1
jvoung (off chromium)
lgtm
6 years, 6 months ago (2014-06-26 20:31:26 UTC) #2
Jim Stichnoth
6 years, 6 months ago (2014-06-26 20:32:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rcc27a53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698