Issue 344063004: Subzero: Add 'not' to the list of LLVM commands in lit.cfg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 344063004: Subzero: Add 'not' to the list of LLVM commands in lit.cfg. (Closed)

Created:
6 years, 6 months ago by Jim Stichnoth

Modified:
6 years, 6 months ago

Reviewers:
jvoung (off chromium), wala

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Add 'not' to the list of LLVM commands in lit.cfg. Without this being in the command substitutions list, lit will rely on the 'not' command being in $PATH. The substitution code is adapted from llvm/test/lit.cfg to add word-break regexps to the list. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cc27a53

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tests_lit/lit.cfg	View		3 chunks	+11 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Jim Stichnoth

6 years, 6 months ago (2014-06-26 20:32:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rcc27a53 (presubmit successful).