Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344053002: Refactoring QuicClient so it doesn't own the epoll server it uses. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton, alyssar
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Refactoring QuicClient so it doesn't own the epoll server it uses. We'll be using QuicClient to health check backends for UdpProxying, so it'll need to use the siloed internal server's EpollServer. Refactoring quic client to not own the epoll server Merge internal change: 69460313 R=alyssar@google.com, rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -30 lines) Patch
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client.h View 3 chunks +8 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.cc View 8 chunks +17 lines, -9 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 4 chunks +8 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 8 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-19 19:27:13 UTC) #1
alyssar
6 years, 6 months ago (2014-06-19 19:41:29 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698