[Password Manager] Disable saving and filling on sync signup

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
+#include "chrome/common/url_constants.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/content/browser/password_manager_internals_service_factory.h"
 #include "components/password_manager/core/browser/log_receiver.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/password_manager/core/browser/password_manager_internals_service.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/common/password_manager_switches.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/password_authentication_manager.h"
 #endif  // OS_ANDROID
 
 using password_manager::PasswordManagerInternalsService;
 using password_manager::PasswordManagerInternalsServiceFactory;
 
@@ skipping 53 matching lines @@
     service->UnregisterClient(this);
 }
 
 bool ChromePasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {
   return CommandLine::ForCurrentProcess()->HasSwitch(
              password_manager::switches::kEnableAutomaticPasswordSaving) &&
          chrome::VersionInfo::GetChannel() ==
              chrome::VersionInfo::CHANNEL_UNKNOWN;
 }
 
+bool ChromePasswordManagerClient::IsPasswordManagerEnabledForCurrentPage()
+    const {
+  DCHECK(web_contents());
+  content::NavigationEntry* entry =
+      web_contents()->GetController().GetLastCommittedEntry();
+  if (!entry) {
+    NOTREACHED();

[vabr (Chromium), 2014/06/24 08:49:49]

Could we leave out the NOTREACHED?
I'm currently working on http://crbug.com/384328, which deals with a very
similar NOTREACHED in DidLastPageLoadEncounterSSLErrors, triggered during Basic
HTTP Auth, which is apparently processed before the entry is committed.
Even though I'm not sure yet if IsPasswordManagerEnabledForCurrentPage could be
triggered this way, I'd feel more comfortable if the password manager code
allowed for being called before the entry is committed.

[vabr (Chromium), 2014/06/24 14:28:24]

I looked into the NOTREACHED a bit more: http://crbug.com/388246

It seems to me like it expresses a wrong expectation. Since it is not affecting
the Release builds anyway, I don't think we make the situation worse if we
remove the NOTREACHED from this CL.

You might want to put here a TODO mentioning http://crbug.com/388246, which is
tracking the problem.

[Garrett Casto, 2014/07/07 21:09:02]

Added.

+    return true;
+  }
+  // We neither fill nor save password when a user is signing in for sync. This
+  // is because users need to remember their password if they are syncing as
+  // this is effectively their master password.
+  return entry->GetURL().host() != chrome::kChromeUIChromeSigninHost;

[Roger Tawa OOO till Jul 10th, 2014/06/26 14:15:05]

The chrome://chrome-signin/ page hosts a regular gaia page at
https://accounts.google.com/  That's OK?

[Garrett Casto, 2014/07/07 21:09:02]

Yeah, as long as we can uniquely identify the page that is used for signin it
doesn't particularly matter what the actual content is.

+}
+
 void ChromePasswordManagerClient::PromptUserToSavePassword(
     password_manager::PasswordFormManager* form_to_save) {
   if (IsTheHotNewBubbleUIEnabled()) {
     ManagePasswordsUIController* manage_passwords_ui_controller =
         ManagePasswordsUIController::FromWebContents(web_contents());
     if (manage_passwords_ui_controller) {
       manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save);
     } else {
       delete form_to_save;
     }
@@ skipping 213 matching lines @@
           web_contents(),
           web_contents()->GetNativeView());
   popup_controller_->Show(false /* display_password */);
 #endif  // defined(USE_AURA) || defined(OS_MACOSX)
 }
 
 void ChromePasswordManagerClient::CommitFillPasswordForm(
     autofill::PasswordFormFillData* data) {
   driver_.FillPasswordForm(*data);
 }