Use PNaCl in V2 builds of the remoting webapp

Use PNaCl in V2 builds of the remoting webapp

Also disabled click-to-play logic for PNaCl plugin

BUG=276739
R=jamiewalch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278886

[Jamie, 2014-06-20 01:11:15]

lgtm

https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gypi
File remoting/remoting_client.gypi (right):

https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gyp...
remoting/remoting_client.gypi:117: 'conditions': [
Can you have conditions inside targets? It would make this change more obvious
if you removed the old pnacl target and moved its condition to the old v2
target.

[Sergey Ulanov, 2014-06-20 18:43:14]

Now reverted change in manifest.json.jinja2 and build-webapp.py, so it's still
possible to build v2 without pnacl.

On 2014/06/20 01:11:15, Jamie wrote:
> lgtm
> 
> https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gypi
> File remoting/remoting_client.gypi (right):
> 
>
https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gyp...
> remoting/remoting_client.gypi:117: 'conditions': [
> Can you have conditions inside targets? It would make this change more obvious
> if you removed the old pnacl target and moved its condition to the old v2
> target.

[Sergey Ulanov, 2014-06-20 18:43:19]

https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gypi
File remoting/remoting_client.gypi (right):

https://codereview.chromium.org/343983003/diff/1/remoting/remoting_client.gyp...
remoting/remoting_client.gypi:117: 'conditions': [
On 2014/06/20 01:11:15, Jamie wrote:
> Can you have conditions inside targets? It would make this change more obvious
> if you removed the old pnacl target and moved its condition to the old v2
> target.

Done.

[Jamie, 2014-06-20 18:46:11]

lgtm

[Sergey Ulanov, 2014-06-20 20:04:09]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-06-20 20:07:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyu@chromium.org/343983003/60001

[commit-bot: I haz the power, 2014-06-21 00:56:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Sergey Ulanov, 2014-06-21 01:08:58]

Committed patchset #4 manually as r278886 (presubmit successful).