[New Multicolumn] Skip tests in fast/multicol intended for region based multicolumns.

[New Multicolumn] Skip tests in fast/multicol intended for region based multicolumns.

A bunch of tests in fast/multicol have baselines generated based on the
region based multicolumn implementation. These tests currently enable the
new multicolumn implementation via Javascript.

This patch skips those tests in the regular fast/multicol suite, leaving
virtual/regionbasedmulticol to run those tests instead. The test suite
virtual/regionbasedmulticol enables the new multicolumn behavior via a
command line flag, so it's no longer necessary to enable it via Javascript
(although they still ineffectively do that, for now).

Note that (ref)tests in fast/multicol/newmulticol/compare-with-old-impl
are special, because the they require the region based multicol
implementation in the test itself, and the old implementation in the
expected result. Hence, these tests should still run in the regular
fast/multicol suite.

BUG=334335
R=rune@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177493

[rune, 2014-06-30 20:52:01]

lgtm, but wait to let jchaffraix have a chance to comment. 

I don't know if there are better alternatives to skip in TestExpectations. I
think skipping is better than creating a baseline for these tests for the old
implementation, at least.

[Julien - ping for review, 2014-06-30 21:00:42]

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1149: # the baseline is based on the region based
multicol imlpementation.
typo: im*lp*ementation

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1216: crbug.com/350853
fast/multicol/newmulticol/unresolvable-percent-max-height.html [ Skip ]
Should we just skip fast/multicol/newmulticol/ ?

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1224: crbug.com/350853 fast/multicol/widows2.html [
Skip ]
I would be of the mindset of enabling the virtual test suite first or as part of
this change [1] to avoid a loss of test coverage (Skip will ignore the test
altogether so it can start crashing or failing and you won't know it until you
have the virtual test suite).

[1] It should be a simple entry in Scripts/webkitpy/layout_tests/port/base.py
for now. We can make it smarter later.

[rune, 2014-06-30 21:12:28]

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1216: crbug.com/350853
fast/multicol/newmulticol/unresolvable-percent-max-height.html [ Skip ]
On 2014/06/30 21:00:42, Julien Chaffraix - PST wrote:
> Should we just skip fast/multicol/newmulticol/ ?

Ah. I didn't know it was possible to skip a whole directory.

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1224: crbug.com/350853 fast/multicol/widows2.html [
Skip ]
On 2014/06/30 21:00:42, Julien Chaffraix - PST wrote:
> I would be of the mindset of enabling the virtual test suite first or as part
of
> this change [1] to avoid a loss of test coverage (Skip will ignore the test
> altogether so it can start crashing or failing and you won't know it until you
> have the virtual test suite).
> 
> [1] It should be a simple entry in Scripts/webkitpy/layout_tests/port/base.py
> for now. We can make it smarter later.

There are two more CLs. The virtual test suite is here:

https://codereview.chromium.org/343963002/

and then there's:

https://codereview.chromium.org/341103002/

@andersr has a plan to land them in the right order.

[Julien - ping for review, 2014-06-30 21:25:18]

lgtm

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/343973002/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:1224: crbug.com/350853 fast/multicol/widows2.html [
Skip ]
On 2014/06/30 21:12:28, rune (futhark.irc - CET) wrote:
> On 2014/06/30 21:00:42, Julien Chaffraix - PST wrote:
> > I would be of the mindset of enabling the virtual test suite first or as
part
> of
> > this change [1] to avoid a loss of test coverage (Skip will ignore the test
> > altogether so it can start crashing or failing and you won't know it until
you
> > have the virtual test suite).
> > 
> > [1] It should be a simple entry in
Scripts/webkitpy/layout_tests/port/base.py
> > for now. We can make it smarter later.
> 
> There are two more CLs. The virtual test suite is here:
> 
> https://codereview.chromium.org/343963002/
> 
> and then there's:
> 
> https://codereview.chromium.org/341103002/
> 
> @andersr has a plan to land them in the right order.

OK, I saw the other changes after I commented. Good to see you have a great way
forward.

[andersr, 2014-07-03 19:29:40]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-07-03 19:30:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/343973002/40001

[andersr, 2014-07-03 19:51:27]

The CQ bit was unchecked by andersr@opera.com

[andersr, 2014-07-03 21:18:26]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-07-03 21:19:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/343973002/60001

[commit-bot: I haz the power, 2014-07-03 22:23:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/14181)

[commit-bot: I haz the power, 2014-07-04 00:23:56]

Change committed as 177493