Issue 343963003: Fix a barback bug where a closed stream could get an event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343963003: Fix a barback bug where a closed stream could get an event. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a barback bug where a closed stream could get an event. R=rnystrom@google.com BUG=19540 Committed: https://code.google.com/p/dart/source/detail?r=37519

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -3 lines)			Patch
M	pkg/barback/CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/phase.dart	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/test/package_graph/add_remove_transform_test.dart	View	1 chunk	+27 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/343963003/diff/1/pkg/barback/test/package_graph/add_remove_transform_test.dart File pkg/barback/test/package_graph/add_remove_transform_test.dart (right): https://codereview.chromium.org/343963003/diff/1/pkg/barback/test/package_graph/add_remove_transform_test.dart#newcode365 pkg/barback/test/package_graph/add_remove_transform_test.dart:365: solo_test("a phase is removed and then one of ...

6 years, 6 months ago (2014-06-19 21:07:29 UTC) #2

nweiz

Committed patchset #1 manually as r37519 (presubmit successful).

6 years, 6 months ago (2014-06-19 21:10:21 UTC) #3

nweiz

6 years, 6 months ago (2014-06-19 21:10:53 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/343963003/diff/1/pkg/barback/test/package_gra...
File pkg/barback/test/package_graph/add_remove_transform_test.dart (right):

https://codereview.chromium.org/343963003/diff/1/pkg/barback/test/package_gra...
pkg/barback/test/package_graph/add_remove_transform_test.dart:365: solo_test("a
phase is removed and then one of its inputs is updated", () {
On 2014/06/19 21:07:29, Bob Nystrom wrote:
> Don't solo! :)

I dunno, I think this is probably the only really important test in this file.

Expand Messages | Collapse Messages