Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 343963002: [New Multicolumn] Create a virtual testsuite for the region based multicol impl. (Closed)

Created:
6 years, 6 months ago by andersr
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Create a virtual testsuite for the region based multicol impl. It is currently possible to switch between the old and the new multicol implementation though Javascript. This means that individual tests may "choose" in which implementation they should be evaluated. We wish to remove the use of this Javascript toggle where it's not necessary (ultimately everywhere), and use virtual test suites instead---even in the transitional period where both implementations exist. This patch is the first in a series which aims to fix this. The virtual/regionbasedmulticol suite tests everything in fast/multicol, except the tests which fail because the baseline is based on the old implementation of multicol. The skipped tests should later be evaluated individually, and baselined in the virtual/regionbasedmulticol suite, if applicable. I have verified that all the tests we skip in the virtual test suite use the old multicol implementation. Note: The tests fast/multicol/mixed-opacity-test.html and multicol/mixed-opacity-fixed-test.html are "new" tests which fail due to a known bug. BUG=334335 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177488

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Mark test as Failure on Mac. #

Patch Set 4 : ImageOnlyFailure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 3 chunks +102 lines, -0 lines 0 comments Download
A LayoutTests/virtual/regionbasedmulticol/fast/multicol/README.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (1 generated)
andersr
6 years, 6 months ago (2014-06-19 16:50:58 UTC) #1
rune
lgtm you should add a BUG= pointing to the main issue for the multicol rewrite, ...
6 years, 6 months ago (2014-06-20 12:31:49 UTC) #2
rune
6 years, 5 months ago (2014-06-30 21:08:39 UTC) #3
Julien - ping for review
lgtm
6 years, 5 months ago (2014-06-30 21:24:03 UTC) #4
Julien - ping for review
+Dirk, Tools/OWNERs needed for a new virtual test suite.
6 years, 5 months ago (2014-06-30 21:31:22 UTC) #5
Dirk Pranke
lgtm
6 years, 5 months ago (2014-06-30 22:02:45 UTC) #6
andersr
The CQ bit was checked by andersr@opera.com
6 years, 5 months ago (2014-07-01 07:29:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/343963002/20001
6 years, 5 months ago (2014-07-01 07:30:22 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-01 08:36:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 09:44:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/14513)
6 years, 5 months ago (2014-07-01 09:44:12 UTC) #11
andersr
The CQ bit was checked by andersr@opera.com
6 years, 5 months ago (2014-07-03 09:41:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/343963002/40001
6 years, 5 months ago (2014-07-03 09:41:43 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-03 11:04:09 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 11:42:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/14108)
6 years, 5 months ago (2014-07-03 11:42:49 UTC) #16
andersr
The CQ bit was checked by andersr@opera.com
6 years, 5 months ago (2014-07-03 18:21:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/343963002/60001
6 years, 5 months ago (2014-07-03 18:22:30 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 19:26:37 UTC) #19
Message was sent while issue was closed.
Change committed as 177488

Powered by Google App Engine
This is Rietveld 408576698