Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 343943005: Clang update.py: don't guard update of LLVM_WIN_REVISION on sys.platform check (Closed)

Created:
6 years, 6 months ago by hans
Modified:
6 years, 6 months ago
Reviewers:
Reid Kleckner, Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Clang update.py: don't guard update of LLVM_WIN_REVISION on sys.platform check The varibale is only relevant on Windows, so this check seems redundant to me. BUG=82385 NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Not a big deal, but I figured this simplifies the code a little.
6 years, 6 months ago (2014-06-19 21:21:19 UTC) #1
Reid Kleckner
lgtm It made more sense when I was trying to live in the future, but ...
6 years, 6 months ago (2014-06-19 21:25:36 UTC) #2
Nico
lgtm On Thu, Jun 19, 2014 at 2:25 PM, <rnk@chromium.org> wrote: > lgtm > > ...
6 years, 6 months ago (2014-06-19 21:36:47 UTC) #3
Nico
lgtm
6 years, 6 months ago (2014-06-19 21:43:19 UTC) #4
hans
6 years, 6 months ago (2014-06-19 21:49:30 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698