Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 343943003: Remove secondary version of speex BUILD file. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, scottmg
Project:
chromium
Visibility:
Public.

Description

Remove secondary version of speex BUILD file. Now that we rolled the DEPS for speex library, we can use the GN BUILD file directory from src/third_party/speex. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn speex TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
D build/secondary/third_party/speex/BUILD.gn View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing...
6 years, 6 months ago (2014-06-19 18:56:32 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-19 19:17:39 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-19 19:23:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/343943003/1
6 years, 6 months ago (2014-06-19 19:25:37 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 23:48:18 UTC) #5
Message was sent while issue was closed.
Change committed as 278531

Powered by Google App Engine
This is Rietveld 408576698