chrome/browser/ui/passwords/password_manager_presenter.cc - Issue 34393007: [Win] Add option to reauthenticate the OS user before revealing passwords.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.cc

Issue 34393007: [Win] Add option to reauthenticate the OS user before revealing passwords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@password

Patch Set: fix nits. fix error checking on NetUserGetInfo Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_util_win.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/passwords/password_ui_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_manager_presenter.cc

diff --git a/chrome/browser/ui/passwords/password_manager_presenter.cc b/chrome/browser/ui/passwords/password_manager_presenter.cc

index 6223656ac9cd4400150dde90948c0ebb6298ea00..24dd9bb2166fb2fe1814867ed802f684da20df6e 100644

--- a/chrome/browser/ui/passwords/password_manager_presenter.cc

+++ b/chrome/browser/ui/passwords/password_manager_presenter.cc

@@ -17,6 +17,7 @@

#include "chrome/common/url_constants.h"

#include "components/autofill/core/common/password_form.h"

#include "content/public/browser/user_metrics.h"

+#include "content/public/browser/web_contents.h"

PasswordManagerPresenter::PasswordManagerPresenter(

PasswordUIView* password_view)

@@ -95,7 +96,8 @@ void PasswordManagerPresenter::RemovePasswordException(size_t index) {

void PasswordManagerPresenter::RequestShowPassword(size_t index) {

DCHECK_LT(index, password_list_.size());

if (IsAuthenticationRequired()) {

- if (password_manager_util::AuthenticateUser())

+ if (password_manager_util::AuthenticateUser(

+ password_view_->GetWebContents()))

last_authentication_time_ = base::TimeTicks::Now();

else

return;