content/browser/renderer_host/media/media_stream_manager_unittest.cc - Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_manager_unittest.cc

Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased + Addressed Tommis comments except WillDestroyCurrentMessageLoop. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/media_stream_manager.cc ('k') | content/browser/renderer_host/media/media_stream_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/media_stream_manager_unittest.cc b/content/browser/renderer_host/media/media_stream_manager_unittest.cc

index a67237a1ed98e405329423ab2c2461214bf9ca8f..5136e0075d5f729fc7f5afe0d83bce947141096d 100644

--- a/content/browser/renderer_host/media/media_stream_manager_unittest.cc

+++ b/content/browser/renderer_host/media/media_stream_manager_unittest.cc

@@ -77,7 +77,6 @@ class MediaStreamManagerTest : public ::testing::Test {

}

virtual ~MediaStreamManagerTest() {

- media_stream_manager_->WillDestroyCurrentMessageLoop();

tommi (sloooow) - chröme 2013/10/30 14:47:30 as discussed it's probably best to go back to this

perkj_chrome 2013/10/30 16:57:08 Done.

}

MOCK_METHOD1(Response, void(int index));

@@ -129,6 +128,7 @@ TEST_F(MediaStreamManagerTest, MakeAndCancelMediaAccessRequest) {

std::string label = MakeMediaAccessRequest(0);

// No callback is expected.

media_stream_manager_->CancelRequest(label);

+ media_stream_manager_->WillDestroyCurrentMessageLoopForTest();

}

TEST_F(MediaStreamManagerTest, MakeMultipleRequests) {