Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/renderer/media/media_stream_impl.cc

Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to latest code base. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_impl.cc
diff --git a/content/renderer/media/media_stream_impl.cc b/content/renderer/media/media_stream_impl.cc
index db5dc1e8d255b1dfaaaa3cf0310da7a20a57d5b2..ba23860505056a03f63ca8729aadd353aca0d88a 100644
--- a/content/renderer/media/media_stream_impl.cc
+++ b/content/renderer/media/media_stream_impl.cc
@@ -419,12 +419,6 @@ void MediaStreamImpl::CreateWebKitSourceVector(
WebKit::WebVector<WebKit::WebMediaStreamSource>& webkit_sources) {
CHECK_EQ(devices.size(), webkit_sources.size());
for (size_t i = 0; i < devices.size(); ++i) {
- const char* track_type =
- (type == WebKit::WebMediaStreamSource::TypeAudio) ? "a" : "v";
- std::string source_id = base::StringPrintf("%s%s%u", label.c_str(),
- track_type,
- static_cast<unsigned int>(i));
-
const WebKit::WebMediaStreamSource* existing_source =
FindLocalSource(devices[i]);
if (existing_source) {
@@ -434,7 +428,7 @@ void MediaStreamImpl::CreateWebKitSourceVector(
continue;
}
webkit_sources[i].initialize(
- UTF8ToUTF16(source_id),
+ UTF8ToUTF16(devices[i].device.id),
type,
UTF8ToUTF16(devices[i].device.name));
MediaStreamSourceExtraData* source_extra_data(
@@ -530,7 +524,7 @@ const WebKit::WebMediaStreamSource* MediaStreamImpl::FindLocalSource(
it->source.extraData());
const StreamDeviceInfo& active_device = extra_data->device_info();
if (active_device.device.id == device.device.id &&
- active_device.session_id == device.session_id) {
+ active_device.device.type == device.device.type) {
return &it->source;
}
}
« no previous file with comments | « content/public/common/media_stream_request.cc ('k') | content/renderer/media/mock_media_stream_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698