content/public/common/media_stream_request.h - Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/media_stream_request.h

Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased to latest code base. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_host_unittest.cc ('k') | content/public/common/media_stream_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/media_stream_request.h

diff --git a/content/public/common/media_stream_request.h b/content/public/common/media_stream_request.h

index 9e612adadd38f9d14d5e81db9ac865e0ef3a425a..e5400a0601851093600301dc904769fe9610dc07 100644

--- a/content/public/common/media_stream_request.h

+++ b/content/public/common/media_stream_request.h

@@ -26,9 +26,6 @@ enum MediaStreamType {

MEDIA_DEVICE_VIDEO_CAPTURE,

// Mirroring of a browser tab.

- //

- // TODO(serygeu): Remove these values and use MEDIA_DESKTOP_VIDEO_CAPTURE and

- // MEDIA_DESKTOP_AUDIO_CAPTURE.

MEDIA_TAB_AUDIO_CAPTURE,

MEDIA_TAB_VIDEO_CAPTURE,

@@ -164,7 +161,6 @@ struct CONTENT_EXPORT MediaStreamRequest {

int render_process_id,

int render_view_id,

int page_request_id,

- const std::string& tab_capture_device_id,

const GURL& security_origin,

MediaStreamRequestType request_type,

const std::string& requested_audio_device_id,