IDL compiler: merge and simplify EventHandler non-callable value check

Source/bindings/v8/V8Utilities.cpp

Index: Source/bindings/v8/V8Utilities.cpp
diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp
index 71d7493b164bbc2aeb7128e7b8b2535ecaa7da6e..f85217f28100e28b3793afef9f13a423ddc51dfb 100644
--- a/Source/bindings/v8/V8Utilities.cpp
+++ b/Source/bindings/v8/V8Utilities.cpp
@@ -149,10 +149,10 @@ void transferHiddenDependency(v8::Handle<v8::Object> object, EventListener* oldV
                 removeHiddenDependency(object, oldListenerObject, cacheIndex, isolate);
         }
     }
-    // Non-callable input should be treated as null
-    if (!newValue->IsNull() && !newValue->IsFunction())
-        newValue = v8::Null(isolate);
-    if (!newValue->IsNull() && !newValue->IsUndefined())
+    if (!newValue->IsNull()
+        // Non-callable input is treated as null and ignored
+        && newValue->IsFunction()
+        && !newValue->IsUndefined())

[haraken, 2013/10/22 12:05:30]

If IsFunction() is true, both IsNull() and IsUndefined() should be false. Thus,
I think only the IsFunction() check would be enough.

[Nils Barth (inactive), 2013/10/22 12:16:51]

Thanks, changed!
(I wasn't sure about the relation between the various tests.)

         createHiddenDependency(object, newValue, cacheIndex, isolate);
 }