Issue 343923004: Remove some includes from Document.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343923004: Remove some includes from Document.h (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
eseidel

CC:
blink-reviews, blink-reviews-rendering, arv+blink, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, jchaffraix+rendering, pdr., rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove some includes from Document.h Document.h is included a lot, so the less it includes the better. Also, touching the removed header files will now cause less recompilation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176656

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	Source/bindings/v8/ScriptEventListener.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1	4 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/343923004/20001

6 years, 6 months ago (2014-06-20 20:27:36 UTC) #3

Message was sent while issue was closed.

Change committed as 176656

Expand Messages | Collapse Messages