Issue 343883003: [SyncFS] Break up overwriting file/folder creation to two phase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343883003: [SyncFS] Break up overwriting file/folder creation to two phase (Closed)

Created:
6 years, 6 months ago by tzik

Modified:
6 years, 6 months ago

Reviewers:
peria, nhiroki

CC:
chromium-reviews, kinuko+fileapi, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] Break up overwriting file/folder creation to two phase This CL breaks up single non-conflicting overwriting local-to-remote sync to two local-to-remote sync. That happens when local file system has a locally modified file and has a not-modified remote folder at the same path. BUG=344769 TEST=./unit_tests --gtest_filter=DriveBackendSyncTest.*:LocalToRemoteSyncerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278671

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -42 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc	View		4 chunks	+3 lines, -37 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/343883003/1

6 years, 6 months ago (2014-06-20 04:12:03 UTC) #5

Message was sent while issue was closed.

Change committed as 278671

Expand Messages | Collapse Messages