Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 343873002: Gallery.app: Fix thumbnail update of the ribbon in the slide mode. (Closed)

Created:
6 years, 6 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery.app: Fix thumbnail update of the ribbon in the slide mode. Previously Gallery.app tried to create a new element when an image is updated, but the new element does not added to DOM. This CL change the behavior so that the app reuses an existing element. BUG=385535 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278405

Patch Set 1 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ui/file_manager/gallery/js/ribbon.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 6 months ago (2014-06-19 05:00:31 UTC) #1
yoshiki
lgtm
6 years, 6 months ago (2014-06-19 10:37:50 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-19 11:12:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/343873002/20001
6 years, 6 months ago (2014-06-19 11:14:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 15:48:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19197)
6 years, 6 months ago (2014-06-19 15:48:24 UTC) #6
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-19 16:43:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/343873002/20001
6 years, 6 months ago (2014-06-19 16:45:20 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 16:52:55 UTC) #9
Message was sent while issue was closed.
Change committed as 278405

Powered by Google App Engine
This is Rietveld 408576698