Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: ui/views/controls/label.h

Issue 343853002: Fix new avatar button appearance regressions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused label halo code; update example. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/label_button.cc ('k') | ui/views/controls/label.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/label.h
diff --git a/ui/views/controls/label.h b/ui/views/controls/label.h
index f41ce85f26d69c9f9ac983472b25a6baf791b3ac..f146b18d4af46625dba1d51250bc56a6b95bf52a 100644
--- a/ui/views/controls/label.h
+++ b/ui/views/controls/label.h
@@ -60,7 +60,11 @@ class VIEWS_EXPORT Label : public View {
SkColor background_color() const { return background_color_; }
// Set drop shadows underneath the text.
- void set_shadows(const gfx::ShadowValues& shadows) { shadows_ = shadows; }
+ void set_shadows(const gfx::ShadowValues& shadows) {
+ shadows_ = shadows;
+ text_size_valid_ = false;
+ }
+ const gfx::ShadowValues& shadows() const { return shadows_; }
// Sets whether subpixel rendering is used; the default is true, but this
// feature also requires an opaque background color.
@@ -68,9 +72,6 @@ class VIEWS_EXPORT Label : public View {
subpixel_rendering_enabled_ = subpixel_rendering_enabled;
}
- // Set the color of a halo on the painted text (use transparent for none).
- void set_halo_color(SkColor halo_color) { halo_color_ = halo_color; }
-
// Sets the horizontal alignment; the argument value is mirrored in RTL UI.
void SetHorizontalAlignment(gfx::HorizontalAlignment alignment);
gfx::HorizontalAlignment GetHorizontalAlignment() const;
@@ -242,9 +243,6 @@ class VIEWS_EXPORT Label : public View {
gfx::DirectionalityMode directionality_mode_;
gfx::ShadowValues shadows_;
- // The halo color drawn around the text if it is not transparent.
- SkColor halo_color_;
-
// The cached heights to avoid recalculation in GetHeightForWidth().
mutable std::vector<gfx::Size> cached_heights_;
mutable int cached_heights_cursor_;
« no previous file with comments | « ui/views/controls/button/label_button.cc ('k') | ui/views/controls/label.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698