Issue 343853002: Fix new avatar button appearance regressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343853002: Fix new avatar button appearance regressions. (Closed)

Created:
6 years, 6 months ago by msw

Modified:
6 years, 6 months ago

Reviewers:
noms (inactive), sky

CC:
chromium-reviews, tfarina, Elliot Glaysher

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix new avatar button appearance regressions. Fix the NewAvatarButton's border inset values. Replace the halo color with shadowing. Disable subpixel rendering for the button text. Use the default alignment (left) instead of right. Add LabelButton text shadow and subpixel setters. Apply label shadows in LabelButton::GetPreferredSize. Invalidate the Label size when shadows are set. Apply the shadow margins in Label text sizing. Remove unused Label halo code; update the example. See pics from before the regression and after this CL: http://crbug.com/155363#c111 BUG=155363 TEST=New Avatar button looks good. R=noms@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278432

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -40 lines)			Patch
M	chrome/browser/ui/views/profiles/new_avatar_button.cc	View	1	6 chunks	+13 lines, -18 lines	0 comments	Download
M	ui/views/controls/button/label_button.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/views/controls/button/label_button.cc	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	ui/views/controls/label.h	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	ui/views/controls/label.cc	View	1 2	3 chunks	+2 lines, -6 lines	0 comments	Download
M	ui/views/examples/label_example.cc	View	1 2	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/343853002/40001

6 years, 6 months ago (2014-06-19 15:56:11 UTC) #4

Message was sent while issue was closed.

Change committed as 278432

Expand Messages | Collapse Messages

Issue 343853002: Fix new avatar button appearance regressions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix insets, shadow setter, and add subpixel setting. #

Patch Set 3 : Remove unused label halo code; update example. #

Messages