Issue 343843002: mojo: remove need for ShellTestBase::InitMojo

Issue 343843002: mojo: remove need for ShellTestBase::InitMojo (Closed)

Created:
6 years, 6 months ago by tim (not reviewing)

Modified:
6 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: remove need for ShellTestBase::InitMojo ChildProcessTest is really just a unit test, so can use testing::Test directly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279503

Patch Set 1 #

Total comments: 2

Patch Set 2 : review nit #

Patch Set 3 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -36 lines)			Patch
M	mojo/shell/child_process_host_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	mojo/shell/shell_test_base.h	View	1	2 chunks	+6 lines, -17 lines	0 comments	Download
M	mojo/shell/shell_test_base.cc	View	1 2	3 chunks	+2 lines, -13 lines	0 comments	Download
M	mojo/shell/shell_test_base_unittest.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM w/tiny nit. https://codereview.chromium.org/343843002/diff/1/mojo/shell/shell_test_base.h File mojo/shell/shell_test_base.h (right): https://codereview.chromium.org/343843002/diff/1/mojo/shell/shell_test_base.h#newcode20 mojo/shell/shell_test_base.h:20: nit: You can delete this blank ...

6 years, 6 months ago (2014-06-18 23:57:13 UTC) #1

tim (not reviewing)

https://codereview.chromium.org/343843002/diff/1/mojo/shell/shell_test_base.h File mojo/shell/shell_test_base.h (right): https://codereview.chromium.org/343843002/diff/1/mojo/shell/shell_test_base.h#newcode20 mojo/shell/shell_test_base.h:20: On 2014/06/18 23:57:13, viettrungluu wrote: > nit: You can ...

6 years, 6 months ago (2014-06-19 00:04:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/343843002/20001

6 years, 6 months ago (2014-06-19 00:06:27 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-19 05:59:12 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18810)

6 years, 6 months ago (2014-06-19 05:59:13 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/343843002/40001

6 years, 6 months ago (2014-06-24 18:29:34 UTC) #8

Message was sent while issue was closed.

Change committed as 279503

Expand Messages | Collapse Messages