chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 343823002: Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 343823002: Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move GenerateKeyword() Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/resettable_settings_snapshot.cc ('k') | chrome/browser/search_engines/search_host_to_urls_map.cc » ('j') | chrome/browser/search_engines/template_url.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index d88c2bacbf00fc5c52ca0e2541b02a6d953ea4ae..cb67ad2ee5910a73b1713ab7bba373006dad2eb4 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -1837,8 +1837,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

SearchEngineTabHelper::FromWebContents(source_web_contents_);

if (search_engine_tab_helper &&

search_engine_tab_helper->delegate()) {

- base::string16 keyword(

- TemplateURLService::GenerateKeyword(params_.page_url));

+ base::string16 keyword(TemplateURL::GenerateKeyword(params_.page_url));

TemplateURLData data;

data.short_name = keyword;

data.SetKeyword(keyword);