chrome/browser/autocomplete/base_search_provider.cc - Issue 343823002: Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/base_search_provider.cc

Issue 343823002: Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autocomplete/base_search_provider.cc

diff --git a/chrome/browser/autocomplete/base_search_provider.cc b/chrome/browser/autocomplete/base_search_provider.cc

index 70833e992478e19fd5cfe3c1d7b6cde97c0251a1..1687be2b642847cbe6690cc7c6b30353a8920aa1 100644

--- a/chrome/browser/autocomplete/base_search_provider.cc

+++ b/chrome/browser/autocomplete/base_search_provider.cc

@@ -466,8 +466,7 @@ void BaseSearchProvider::SetDeletionURL(const std::string& deletion_url,

TemplateURLServiceFactory::GetForProfile(profile_);

if (!template_service)

return;

- GURL url = TemplateURLService::GenerateSearchURL(

- template_service->GetDefaultSearchProvider(),

+ GURL url = template_service->GetDefaultSearchProvider()->GenerateSearchURL(

template_service->search_terms_data());

url = url.GetOrigin().Resolve(deletion_url);

if (url.is_valid()) {

« no previous file with comments | « no previous file | chrome/browser/importer/in_process_importer_bridge.cc » ('j') | chrome/browser/search_engines/template_url.h » ('J')