Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4724)

Unified Diff: chrome/browser/search_engines/template_url_service_unittest.cc

Issue 343823002: Move GenerateSearchURL() and GenerateKeyword() from TemplateURLService to TemplateURL (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_unittest.cc b/chrome/browser/search_engines/template_url_service_unittest.cc
index e2669acdba3fbae1b53acb236c6696139ca3f679..b3c2109a01937c4bff8a6a2d9bddc730facfb6cc 100644
--- a/chrome/browser/search_engines/template_url_service_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_unittest.cc
@@ -510,45 +510,6 @@ TEST_F(TemplateURLServiceTest, AddSameKeywordWithExtensionPresent) {
model()->GetTemplateURLForKeyword(ASCIIToUTF16("keyword_")));
}
-TEST_F(TemplateURLServiceTest, GenerateKeyword) {
- ASSERT_EQ(ASCIIToUTF16("foo"),
- TemplateURLService::GenerateKeyword(GURL("http://foo")));
- // www. should be stripped.
- ASSERT_EQ(ASCIIToUTF16("foo"),
- TemplateURLService::GenerateKeyword(GURL("http://www.foo")));
- // Make sure we don't get a trailing '/'.
- ASSERT_EQ(ASCIIToUTF16("blah"),
- TemplateURLService::GenerateKeyword(GURL("http://blah/")));
- // Don't generate the empty string.
- ASSERT_EQ(ASCIIToUTF16("www"),
- TemplateURLService::GenerateKeyword(GURL("http://www.")));
-}
-
-TEST_F(TemplateURLServiceTest, GenerateSearchURL) {
- TestSearchTermsData search_terms_data("http://google.com/");
-
- struct GenerateSearchURLCase {
- const char* test_name;
- const char* url;
- const char* expected;
- } generate_url_cases[] = {
- { "invalid URL", "foo{searchTerms}", "" },
- { "URL with no replacements", "http://foo/", "http://foo/" },
- { "basic functionality", "http://foo/{searchTerms}",
- "http://foo/blah.blah.blah.blah.blah" }
- };
-
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(generate_url_cases); ++i) {
- TemplateURLData data;
- data.SetURL(generate_url_cases[i].url);
- TemplateURL t_url(data);
- std::string result = TemplateURLService::GenerateSearchURL(
- &t_url, search_terms_data).spec();
- EXPECT_EQ(result, generate_url_cases[i].expected)
- << generate_url_cases[i].test_name << " failed.";
- }
-}
-
TEST_F(TemplateURLServiceTest, ClearBrowsingData_Keywords) {
Time now = Time::Now();
TimeDelta one_day = TimeDelta::FromDays(1);
@@ -865,8 +826,7 @@ TEST_F(TemplateURLServiceTest, RepairPrepopulatedSearchEngines) {
// The keyword wasn't reverted.
EXPECT_EQ(ASCIIToUTF16("trash"), google->short_name());
EXPECT_EQ("www.google.com",
- TemplateURLService::GenerateSearchURL(
- google, model()->search_terms_data()).host());
+ google->GenerateSearchURL(model()->search_terms_data()).host());
// Bing was repaired.
bing = model()->GetTemplateURLForKeyword(ASCIIToUTF16("bing.com"));
« no previous file with comments | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/search_engines/template_url_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698