Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 343813006: Drop --clone from skia (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Drop --clone from commands in skia repo. --clone, and SkPicture::clone(), are no longer. CQ_EXTRA_TRYBOTS=tryserver.skia:Housekeeper-PerCommit-Trybot BUG=skia: R=rmistry@google.com Committed: https://skia.googlesource.com/skia/+/a40239c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gm/rebaseline_server/compare_rendered_pictures_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/tests/render_pictures_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 5 months ago (2014-06-27 21:04:45 UTC) #1
rmistry
LGTM
6 years, 5 months ago (2014-06-27 21:06:15 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-06-27 21:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/343813006/1
6 years, 5 months ago (2014-06-27 21:08:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-27 21:08:55 UTC) #5
commit-bot: I haz the power
Presubmit check for 343813006-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-06-27 21:08:55 UTC) #6
mtklein_C
6 years, 5 months ago (2014-06-27 21:09:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as ra40239c.

Powered by Google App Engine
This is Rietveld 408576698