Issue 343783002: remove guarded code - there are no more callers

Issue 343783002: remove guarded code - there are no more callers (Closed)

Created:
6 years, 6 months ago by reed1

Modified:
6 years, 6 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

remove guarded code - there are no more callers BUG=skia: Committed: https://skia.googlesource.com/skia/+/c5d5cf9489977aa6fba077d1dc242029fbb4859e

Patch Set 2 : make constructors private #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -58 lines)			Patch
M	include/core/SkCanvas.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/effects/SkLayerRasterizer.h	View	1	4 chunks	+4 lines, -26 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	src/core/SkPaintPriv.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/effects/SkLayerRasterizer.cpp	View		3 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h File include/effects/SkLayerRasterizer.h (right): https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h#newcode77 include/effects/SkLayerRasterizer.h:77: SkLayerRasterizer(); Can this be private? (I don't think ...

6 years, 6 months ago (2014-06-18 21:23:04 UTC) #2

reed1

https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h File include/effects/SkLayerRasterizer.h (right): https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h#newcode77 include/effects/SkLayerRasterizer.h:77: SkLayerRasterizer(); On 2014/06/18 21:23:04, scroggo wrote: > Can this ...

6 years, 6 months ago (2014-06-18 21:26:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/343783002/20001

6 years, 6 months ago (2014-06-18 21:27:34 UTC) #5

scroggo

On 2014/06/18 21:26:09, reed1 wrote: > https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h > File include/effects/SkLayerRasterizer.h (right): > > https://codereview.chromium.org/343783002/diff/1/include/effects/SkLayerRasterizer.h#newcode77 > ...

6 years, 6 months ago (2014-06-18 21:27:41 UTC) #6

commit-bot: I haz the power

Change committed as c5d5cf9489977aa6fba077d1dc242029fbb4859e

6 years, 6 months ago (2014-06-18 21:41:30 UTC) #7

reed2

6 years, 6 months ago (2014-06-18 22:50:06 UTC) #8

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/342843002/ by reed@chromium.org.

The reason for reverting is: webkit still uses getTotalClip -- need to find
where they define the guard.

../../skia/ext/skia_utils_mac.mm:400:42: error: no member named 'getTotalClip'
in 'SkCanvas'
      const SkRegion& clipRgn = canvas_->getTotalClip();
                                ~~~~~~~  ^
.

Expand Messages | Collapse Messages