Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 343763002: Add PLATFORM_EXPORT to MediaStreamComponent::AudioSourceProviderImpl (Closed)

Created:
6 years, 6 months ago by hans
Modified:
6 years, 6 months ago
Reviewers:
Reid Kleckner, Nico
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add PLATFORM_EXPORT to MediaStreamComponent::AudioSourceProviderImpl On non-Windows, PLATFORM_EXPORT expands to a visibility attribute, which is inherited by nested classes. On Windows, it's expanded to a dllexport/dllimport attribute, which is not inherited. When using Clang on Windows, MediaStreamComponent's dtor got inlined, which destroys m_sourceProvider, whose destructor got inlined, and tried to reference provideInput for the vtable, but failed to link since it wasn't in the right dll. Exporting the inner class fixes this. BUG=82385 TEST=build blink_web.dll with Clang on Windows in Release mode Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176468

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/mediastream/MediaStreamComponent.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 15 (0 generated)
hans
Please take a look.
6 years, 6 months ago (2014-06-18 20:31:26 UTC) #1
Nico
lgtm
6 years, 6 months ago (2014-06-18 20:43:24 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 6 months ago (2014-06-18 20:43:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/343763002/1
6 years, 6 months ago (2014-06-18 20:45:05 UTC) #4
Reid Kleckner
There is no inline ctor, so I think it must have been the dtor and ...
6 years, 6 months ago (2014-06-18 20:45:30 UTC) #5
hans
The CQ bit was unchecked by hans@chromium.org
6 years, 6 months ago (2014-06-18 20:49:44 UTC) #6
Nico
https://codereview.chromium.org/343763002/diff/1/Source/platform/mediastream/MediaStreamComponent.h File Source/platform/mediastream/MediaStreamComponent.h (right): https://codereview.chromium.org/343763002/diff/1/Source/platform/mediastream/MediaStreamComponent.h#newcode84 Source/platform/mediastream/MediaStreamComponent.h:84: AudioSourceProviderImpl() Isn't this a ctor?
6 years, 6 months ago (2014-06-18 20:49:53 UTC) #7
hans
On 2014/06/18 20:49:53, Nico (away) wrote: > https://codereview.chromium.org/343763002/diff/1/Source/platform/mediastream/MediaStreamComponent.h > File Source/platform/mediastream/MediaStreamComponent.h (right): > > https://codereview.chromium.org/343763002/diff/1/Source/platform/mediastream/MediaStreamComponent.h#newcode84 ...
6 years, 6 months ago (2014-06-18 20:54:06 UTC) #8
hans
The CQ bit was checked by hans@chromium.org
6 years, 6 months ago (2014-06-18 20:59:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/343763002/1
6 years, 6 months ago (2014-06-18 21:00:23 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 23:28:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12592)
6 years, 6 months ago (2014-06-18 23:28:17 UTC) #12
hans
The CQ bit was checked by hans@chromium.org
6 years, 6 months ago (2014-06-18 23:29:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/343763002/1
6 years, 6 months ago (2014-06-18 23:29:41 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 00:45:37 UTC) #15
Message was sent while issue was closed.
Change committed as 176468

Powered by Google App Engine
This is Rietveld 408576698