Fix a leak in wm::AnimateOnChildWindowVisibilityChanged().

ui/wm/core/window_animations_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/wm/core/window_animations.h"
 
 #include "base/time/time.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
@@ skipping 270 matching lines @@
   wm::SetWindowVisibilityAnimationType(
       window.get(), WINDOW_VISIBILITY_ANIMATION_TYPE_FADE);
   AnimateOnChildWindowVisibilityChanged(window.get(), true);
   EXPECT_TRUE(window->layer()->visible());
 
   EXPECT_FALSE(animation_host.hide_completed());
   AnimateOnChildWindowVisibilityChanged(window.get(), false);
   EXPECT_TRUE(animation_host.hide_completed());
 }
 
+// The rotation animation for hiding a window should not leak the animation
+// observer.
+TEST_F(WindowAnimationsTest, RotateHideNoLeak) {
+  ui::ScopedAnimationDurationScaleMode scale_mode(
+      ui::ScopedAnimationDurationScaleMode::FAST_DURATION);
+
+  scoped_ptr<aura::Window> window(aura::test::CreateTestWindowWithId(0, NULL));
+  ui::Layer* animating_layer = window->layer();
+  wm::SetWindowVisibilityAnimationType(window.get(),
+                                       WINDOW_VISIBILITY_ANIMATION_TYPE_ROTATE);
+
+  AnimateOnChildWindowVisibilityChanged(window.get(), true);
+  AnimateOnChildWindowVisibilityChanged(window.get(), false);
+
+  EXPECT_NO_FATAL_FAILURE(animating_layer->GetAnimator()->StopAnimating());

[sky, 2014/07/17 15:59:40]

None of the call you're calling in this macro asserts/expects. So there is no
point in wrapping it in EXPECT_NO_FATAL_FAILURE.

[please use gerrit instead, 2014/07/17 19:43:46]

Done.

+}
+
 }  // namespace wm