Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: content/public/browser/push_messaging_service.h

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments from Peter, Bernhard and Elliot Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/push_messaging_service.h
diff --git a/content/public/browser/push_messaging_service.h b/content/public/browser/push_messaging_service.h
index 37150db783b1c4ab11348e77cd5499f4bbef65bd..c2a97201d64a4371bb6d3faa97651b944bb1423d 100644
--- a/content/public/browser/push_messaging_service.h
+++ b/content/public/browser/push_messaging_service.h
@@ -25,6 +25,8 @@ class CONTENT_EXPORT PushMessagingService {
virtual ~PushMessagingService() {}
virtual void Register(const std::string& app_id,
const std::string& sender_id,
+ const int renderer_id,
jianli 2014/06/20 17:19:30 nit: no need to add const
Miguel Garcia 2014/06/20 20:50:13 Done.
+ const int routing_id,
jam 2014/06/20 15:55:01 nit: what is routing_id? usually we disambiguate b
Miguel Garcia 2014/06/20 20:50:13 Done.
const RegisterCallback& callback) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698