Implement a permission check for push.

chrome/browser/services/gcm/permission_context_base.cc

Index: chrome/browser/services/gcm/permission_context_base.cc
diff --git a/chrome/browser/services/gcm/permission_context_base.cc b/chrome/browser/services/gcm/permission_context_base.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a9b97b9ace54c4793aa797ee8ab454549d3609e4
--- /dev/null
+++ b/chrome/browser/services/gcm/permission_context_base.cc
@@ -0,0 +1,111 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/services/gcm/permission_context_base.h"
+
+#include "chrome/browser/content_settings/host_content_settings_map.h"
+#include "chrome/browser/content_settings/permission_queue_controller.h"
+#include "chrome/browser/content_settings/permission_request_id.h"
+#include "chrome/browser/content_settings/tab_specific_content_settings.h"
+#include "chrome/browser/profiles/profile.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/web_contents.h"
+
+namespace gcm {
+
+PermissionContextBase::PermissionContextBase(
+    Profile* profile,
+    const ContentSettingsType permission_type)
+    : profile_(profile), permission_type_(permission_type) {
+}
+
+PermissionContextBase::~PermissionContextBase() {
+  DCHECK(!permission_queue_controller_);

[jianli, 2014/06/20 17:19:29]

Please include logging.h.

Since permission_queue_controller_ is delay created, do we need to check for
this? If we do, there is no need to make permission_queue_controller_ delay
created.

[Miguel Garcia, 2014/06/20 20:50:12]

Actually let's create permission_queue_controller in the constructor. I think
this is done this way because once we implement permission bubbles (coming soon)
the queue does not need to be created at all but I think it's just clearer if it
is created in the constructor just like anything else.


On 2014/06/20 17:19:29, jianli wrote:

+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+}
+
+void PermissionContextBase::RequestPermission(
+    content::WebContents* web_contents,
+    const PermissionRequestID& id,
+    const GURL& requesting_frame,
+    bool user_gesture,
+    const BrowserPermissionCallback& callback) {
+  // TODO(miguelg) Add UMA instrumentation

[jianli, 2014/06/20 17:19:29]

nit: add ':' after ')' and end the sentence with period.

[Miguel Garcia, 2014/06/20 20:50:12]

Done.

+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+
+  DecidePermission(web_contents,
+                   id,
+                   requesting_frame,
+                   requesting_frame,
+                   user_gesture,
+                   callback);
+}
+
+void PermissionContextBase::DecidePermission(
+    content::WebContents* web_contents,
+    const PermissionRequestID& id,
+    const GURL& requesting_frame,
+    const GURL& embedder,
+    bool user_gesture,
+    const BrowserPermissionCallback& callback) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+
+  ContentSetting content_setting =
+      profile_->GetHostContentSettingsMap()->GetContentSetting(
+          requesting_frame, embedder, permission_type_, std::string());
+  switch (content_setting) {
+    case CONTENT_SETTING_BLOCK:
+      PermissionDecided(id, requesting_frame, embedder, callback, false);
+      break;
+    case CONTENT_SETTING_ALLOW:
+      PermissionDecided(id, requesting_frame, embedder, callback, true);
+      break;
+    default:
+      // TODO(miguelg) implement bubble support

[jianli, 2014/06/20 17:19:29]

ditto

[Miguel Garcia, 2014/06/20 20:50:12]

Done.

+
+      // TODO(gbillock): Delete this and the infobar delegate when
+      // we're using only bubbles. crbug.com/337458
+      GetQueueController()->CreateInfoBarRequest(
+          id,
+          requesting_frame,
+          embedder,
+          std::string(),
+          base::Bind(&PermissionContextBase::NotifyPermissionSet,
+                     base::Unretained(this),

[fgorski, 2014/06/20 14:14:15]

Will this callback be passed somewhere outside of the
permission_queue_controller_? If so, I think weak_ptr would be better.
Otherwise, could you add a comment explaining what the expectation is?

[Miguel Garcia, 2014/06/20 20:50:12]

Once we implement bubbles it will be passed to the bubble as well but it seems a
similar case, i.e this object will be alive anyway. I'll change it to weak_ptr
as suggested

+                     id,
+                     requesting_frame,
+                     callback));
+  }
+}
+
+void PermissionContextBase::PermissionDecided(
+    const PermissionRequestID& id,
+    const GURL& requesting_frame,
+    const GURL& embedder,
+    const BrowserPermissionCallback& callback,
+    bool allowed) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  NotifyPermissionSet(id, requesting_frame, callback, allowed);
+}
+
+PermissionQueueController* PermissionContextBase::GetQueueController() {
+  if (!permission_queue_controller_) {
+    permission_queue_controller_.reset(
+        new PermissionQueueController(profile_, permission_type_));
+  }
+  return permission_queue_controller_.get();
+}
+
+void PermissionContextBase::NotifyPermissionSet(
+    const PermissionRequestID& id,
+    const GURL& requesting_frame,
+    const BrowserPermissionCallback& callback,
+    bool allowed) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  UpdateTabContext(id, requesting_frame, allowed);
+
+  callback.Run(allowed);
+}
+
+}  // namespace gcm