Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2340)

Unified Diff: chrome/browser/services/gcm/permission_infobar_delegate.cc

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and addressed Michael's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/permission_infobar_delegate.cc
diff --git a/chrome/browser/services/gcm/permission_infobar_delegate.cc b/chrome/browser/services/gcm/permission_infobar_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2bccc4f248e820fd40dcd81df3a9fe209df6db7a
--- /dev/null
+++ b/chrome/browser/services/gcm/permission_infobar_delegate.cc
@@ -0,0 +1,59 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/services/gcm/permission_infobar_delegate.h"
+
+#include "chrome/browser/content_settings/permission_queue_controller.h"
+#include "components/infobars/core/infobar.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace gcm {
+
+PermissionInfobarDelegate::~PermissionInfobarDelegate() {
+}
+
+PermissionInfobarDelegate::PermissionInfobarDelegate(
+ PermissionQueueController* controller,
+ const PermissionRequestID& id,
+ GURL& requesting_frame)
+ : controller_(controller), id_(id), requesting_frame_(requesting_frame) {
+}
+
+void PermissionInfobarDelegate::InfoBarDismissed() {
+ SetPermission(false, false);
+}
+
+infobars::InfoBarDelegate::Type PermissionInfobarDelegate::GetInfoBarType()
+ const {
Peter Kasting 2014/06/19 17:58:20 Nit: "const" should be on same line as last arg (i
Miguel Garcia 2014/06/19 21:49:22 Done.
+ return PAGE_ACTION_TYPE;
+}
+
+base::string16 PermissionInfobarDelegate::GetButtonLabel(
+ InfoBarButton button) const {
+ return l10n_util::GetStringUTF16((button == BUTTON_OK) ? IDS_PERMISSION_ALLOW
+ : IDS_PERMISSION_DENY);
Peter Kasting 2014/06/19 17:58:20 Nit: clang-format error; instead, break after "?"
Miguel Garcia 2014/06/19 21:49:22 Done.
+}
+
+bool PermissionInfobarDelegate::Accept() {
+ SetPermission(true, true);
+ return true;
+}
+
+bool PermissionInfobarDelegate::Cancel() {
+ SetPermission(true, false);
+ return true;
+}
+
+void PermissionInfobarDelegate::SetPermission(bool update_content_setting,
+ bool allowed) {
+ content::WebContents* web_contents =
+ InfoBarService::WebContentsFromInfoBar(infobar());
Peter Kasting 2014/06/19 17:58:20 Nit: You can inline this below if you start the ar
Miguel Garcia 2014/06/19 21:49:22 Done.
+ controller_->OnPermissionSet(id_,
+ requesting_frame_,
+ web_contents->GetURL(),
+ update_content_setting,
+ allowed);
+}
Peter Kasting 2014/06/19 17:58:20 Nit: Blank line below this
Miguel Garcia 2014/06/19 21:49:22 Done.
+} // namespace gcm

Powered by Google App Engine
This is Rietveld 408576698