Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: chrome/browser/content_settings/permission_queue_controller.cc

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and addressed Michael's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_queue_controller.cc
diff --git a/chrome/browser/content_settings/permission_queue_controller.cc b/chrome/browser/content_settings/permission_queue_controller.cc
index 06c84853f59485be4ebb74e79fc98eb59e04f4e7..8981dc7381b2bdfab5b123dfe7aedf320dffa4f5 100644
--- a/chrome/browser/content_settings/permission_queue_controller.cc
+++ b/chrome/browser/content_settings/permission_queue_controller.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/media/midi_permission_infobar_delegate.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/services/gcm/gcm_infobar_delegate.h"
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/common/content_settings.h"
#include "chrome/common/pref_names.h"
@@ -117,6 +118,13 @@ void PermissionQueueController::PendingInfobarRequest::CreateInfoBar(
GetInfoBarService(id_), controller, id_, requesting_frame_,
display_languages);
break;
+ case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
+ infobar_ = gcm::GCMInfoBarDelegate::Create(GetInfoBarService(id_),
Bernhard Bauer 2014/06/19 18:13:18 Nit: Other ::Create methods here put multiple para
Miguel Garcia 2014/06/19 21:49:22 Done.
+ controller,
+ id_,
+ requesting_frame_,
+ display_languages);
+ break;
#if defined(OS_ANDROID)
case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
infobar_ = ProtectedMediaIdentifierInfoBarDelegate::Create(

Powered by Google App Engine
This is Rietveld 408576698