Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/push_messaging_message_filter.cc

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « chrome/test/base/testing_profile.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/push_messaging_message_filter.cc
diff --git a/content/browser/push_messaging_message_filter.cc b/content/browser/push_messaging_message_filter.cc
index 8f15112d681db76fe137f20496423d5fc5368482..4b33d7901509e53f558f93219e4107c4908690ac 100644
--- a/content/browser/push_messaging_message_filter.cc
+++ b/content/browser/push_messaging_message_filter.cc
@@ -57,10 +57,13 @@ void PushMessagingMessageFilter::DoRegister(int routing_id,
DidRegister(routing_id, callbacks_id, GURL(), "", false);
return;
}
+
// TODO(mvanouwerkerk): Pass in app ID based on Service Worker ID.
std::string app_id = "unknown-app-id";
service_->Register(app_id,
sender_id,
+ render_process_id_,
+ routing_id,
base::Bind(&PushMessagingMessageFilter::DidRegister,
weak_factory_.GetWeakPtr(),
routing_id,
« chrome/browser/services/gcm/push_messaging_service_impl.cc ('K') | « chrome/test/base/testing_profile.cc ('k') | content/public/browser/push_messaging_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698