Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: chrome/browser/services/gcm/push_messaging_service_impl.h

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 64aa91ffe0d3401624c2539bff5ff4cf5335fe2c..a3072c00c71c266044f6c08f4268b2af23e5fd76 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
#define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
+#include <vector>
Michael van Ouwerkerk 2014/06/19 10:16:11 Nit: move this to push_messaging_service_impl.cc w
Miguel Garcia 2014/06/19 17:49:28 Done.
+
#include "base/compiler_specific.h"
#include "base/memory/weak_ptr.h"
#include "components/gcm_driver/gcm_client.h"
@@ -23,6 +25,8 @@ class PushMessagingServiceImpl : public content::PushMessagingService {
virtual void Register(
const std::string& app_id,
const std::string& sender_id,
+ const int renderer_id,
+ const int router_id,
const content::PushMessagingService::RegisterCallback& callback) OVERRIDE;
private:
@@ -31,6 +35,12 @@ class PushMessagingServiceImpl : public content::PushMessagingService {
const std::string& registration_id,
GCMClient::Result result);
+ void ShouldProceed(
+ const std::string& sender_id,
+ const std::string& app_id,
+ const content::PushMessagingService::RegisterCallback& callback,
+ bool allow);
+
GCMProfileService* gcm_profile_service_; // It owns us.
base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698