chrome/browser/services/gcm/gcm_permission_context.h - Issue 343743004: Implement a permission check for push.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/services/gcm/gcm_permission_context.h

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments from Peter, Bernhard and Elliot Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_PERMISSION_CONTEXT_H_

	6 #define CHROME_BROWSER_SERVICES_GCM_GCM_PERMISSION_CONTEXT_H_

	7

	8 #include "chrome/browser/services/gcm/permission_context_base.h"

	9

	10 namespace gcm {

	11

	12 // Permission context for push messages.

	13 class GCMPermissionContext : public PermissionContextBase {
	jianli 2014/06/20 17:19:29 Should we name this class as PushMessagingPermissi Should we name this class as PushMessagingPermissionContext? Miguel Garcia 2014/06/20 20:50:12 Done. Show quoted text On 2014/06/20 17:19:29, jianli wrote: > Should we name this class as PushMessagingPermissionContext? Done.
	14 public:

	15 explicit GCMPermissionContext(Profile* profile);

	16 virtual ~GCMPermissionContext();

	17

	18 DISALLOW_COPY_AND_ASSIGN(GCMPermissionContext);
	jianli 2014/06/20 17:19:29 nit: add private scope nit: add private scope Miguel Garcia 2014/06/20 20:50:12 Oops, thanks for catching this one! Show quoted text On 2014/06/20 17:19:29, jianli wrote: > nit: add private scope Oops, thanks for catching this one!
	19 };

	20

	21 } // namespace gcm

	22 #endif // CHROME_BROWSER_SERVICES_GCM_GCM_PERMISSION_CONTEXT_H_

OLD	NEW