Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/browser/services/gcm/gcm_infobar_delegate.h

Issue 343743004: Implement a permission check for push. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments from Peter, Bernhard and Elliot Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_INFOBAR_DELEGATE_H_
6 #define CHROME_BROWSER_SERVICES_GCM_GCM_INFOBAR_DELEGATE_H_
7
8 #include "chrome/browser/services/gcm/permission_infobar_delegate.h"
9
10 class GURL;
11 class InfoBarService;
12
13 namespace gcm {
14
15 // Delegate to allow GCM push messages registration.
16 class GCMInfoBarDelegate : public PermissionInfobarDelegate {
jianli 2014/06/20 17:19:29 The info bar seems to be targeted only for web pus
Miguel Garcia 2014/06/20 20:50:12 Ok, since two people already asked for the same I'
17 public:
18 virtual ~GCMInfoBarDelegate();
19
20 // Creates a Push Permission infobar and delegate and adds the infobar to
21 // |infobar_service|. Returns the infobar if it was successfully added.
22 static infobars::InfoBar* Create(InfoBarService* infobar_service,
23 PermissionQueueController* controller,
24 const PermissionRequestID& id,
25 GURL& requesting_frame,
fgorski 2014/06/20 14:14:15 pass GURL as const &.
Miguel Garcia 2014/06/20 20:50:11 Done.
26 const std::string& display_languages);
27
28 private:
29 GCMInfoBarDelegate(PermissionQueueController* controller,
30 const PermissionRequestID& id,
31 GURL& requesting_frame,
fgorski 2014/06/20 14:14:15 same here
Miguel Garcia 2014/06/20 20:50:12 Done.
32 const std::string& display_languages);
33
34 // ConfirmInfoBarDelegate:
35 virtual base::string16 GetMessageText() const OVERRIDE;
36
37 const GURL requesting_origin_;
38 const std::string& display_languages_;
Peter Kasting 2014/06/19 22:04:31 Having this as a const ref makes me nervous, since
fgorski 2014/06/20 14:14:15 +1
Miguel Garcia 2014/06/20 20:50:11 Done.
Miguel Garcia 2014/06/20 20:50:12 Done.
39
40 DISALLOW_COPY_AND_ASSIGN(GCMInfoBarDelegate);
41 };
42
43 } // namespace gcm
fgorski 2014/06/20 14:14:15 nit: Please add empty line below and make it consi
Miguel Garcia 2014/06/20 20:50:11 Done.
44 #endif // CHROME_BROWSER_SERVICES_GCM_GCM_INFOBAR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698