Implement a permission check for push.

chrome/browser/services/gcm/permission_infobar_delegate.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SERVICES_GCM_PERMISSION_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_SERVICES_GCM_PERMISSION_INFOBAR_DELEGATE_H_
+
+#include "chrome/browser/content_settings/permission_request_id.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "content/public/browser/web_contents.h"
+
+class GURL;
+class NavigationDetails;
+class PermissionQueueController;
+
+namespace gcm {
+
+// Base class for permission infobars, it implements the default behaviour
+// so that the accept/deny buttons grant/deny the relevant permission.
+// A basic implementor only needs to implement the methods that
+// provide an incon and a message text to the infobar.
+class PermissionInfobarDelegate : public ConfirmInfoBarDelegate {

[Peter Kasting, 2014/06/19 17:58:21]

Do you have this base class because your next patch is going to add more
subclasses of it, or something?  It's a bit odd to have this class with only one
subclass that's what everyone actually wants to use.

[Miguel Garcia, 2014/06/19 21:49:22]

Yes, Midi Geolocation and other permission classes do almost exactly the same
thing so the idea is to move this to a common place and reuse it in all of them.
I need to implement bubble support before I do it though. I added a explanation
in the description.

+ public:
+  virtual ~PermissionInfobarDelegate();
+
+ protected:
+  PermissionInfobarDelegate(PermissionQueueController* controller,
+                            const PermissionRequestID& id,
+                            GURL& requesting_frame);
+
+  // ConfirmInfoBarDelegate:
+  virtual void InfoBarDismissed() OVERRIDE;
+  virtual infobars::InfoBarDelegate::Type GetInfoBarType() const OVERRIDE;
+  virtual base::string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+
+ private:
+  void SetPermission(bool update_content_setting, bool allowed);
+
+  PermissionQueueController* controller_;
+  const PermissionRequestID id_;
+  GURL requesting_frame_;
+  DISALLOW_COPY_AND_ASSIGN(PermissionInfobarDelegate);

[Peter Kasting, 2014/06/19 17:58:21]

Nit: Blank line above this so it doesn't blend in with the members

[Miguel Garcia, 2014/06/19 21:49:22]

Done.

+};
+
+}  // namespace gcm

[Peter Kasting, 2014/06/19 17:58:20]

Nit: Blank line below this

[Miguel Garcia, 2014/06/19 21:49:22]

Done.

+#endif  // CHROME_BROWSER_SERVICES_GCM_PERMISSION_INFOBAR_DELEGATE_H_