Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 343743003: Fix breakpad warnings. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix breakpad warnings. This has a warning that seems very dependent on the compiler version. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278466

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M breakpad/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 6 months ago (2014-06-19 19:20:05 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-06-19 19:41:16 UTC) #2
brettw
6 years, 6 months ago (2014-06-19 20:02:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r278466.

Powered by Google App Engine
This is Rietveld 408576698