Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 343733002: Qualify core include file in web and bindings, etc. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, paulirish+reviews_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify core include file in web and bindings, etc. BUG=381876 TBR=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/CustomElementWrapper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8EventTargetCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLDocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8SVGElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/Init.cpp View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebColorName.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSearchableFormData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
c.shu
6 years, 6 months ago (2014-06-18 19:07:22 UTC) #1
rwlbuis
lgtm
6 years, 6 months ago (2014-06-18 19:41:57 UTC) #2
c.shu
On 2014/06/18 19:41:57, rwlbuis wrote: > lgtm Thanks, Rob. I still need lgtm for bindings ...
6 years, 6 months ago (2014-06-18 19:44:46 UTC) #3
haraken
LGTM I guess it's OK to TBR Eric for web/.
6 years, 6 months ago (2014-06-18 23:18:45 UTC) #4
c.shu
On 2014/06/18 23:18:45, haraken wrote: > LGTM > > I guess it's OK to TBR ...
6 years, 6 months ago (2014-06-19 01:44:26 UTC) #5
haraken
On 2014/06/19 01:44:26, c.shu wrote: > On 2014/06/18 23:18:45, haraken wrote: > > LGTM > ...
6 years, 6 months ago (2014-06-19 01:49:38 UTC) #6
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-19 02:38:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/343733002/1
6 years, 6 months ago (2014-06-19 02:38:22 UTC) #8
commit-bot: I haz the power
Change committed as 176479
6 years, 6 months ago (2014-06-19 02:42:10 UTC) #9
eseidel
lgtm
6 years, 6 months ago (2014-06-19 02:47:17 UTC) #10
haraken
6 years, 6 months ago (2014-06-19 03:26:02 UTC) #11
Message was sent while issue was closed.
On 2014/06/19 01:49:38, haraken wrote:
> On 2014/06/19 01:44:26, c.shu wrote:
> > On 2014/06/18 23:18:45, haraken wrote:
> > > LGTM
> > > 
> > > I guess it's OK to TBR Eric for web/.
> > 
> > I pinged Eric on IRC but he was busy at the time.
> 
> For this kind of non-trivial change, you can just add "TBR=xxx" to the CL
> description and then click the commit button before getting his/her approval.
> He/She will hopefully take a look at the CL later and approve it.

s/non-trivial/trivial/ :)

Powered by Google App Engine
This is Rietveld 408576698