Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 343703004: [NaCl SDK] Add bionic SDK bundle auto-updating to update_nacl_manifest (Closed)

Created:
6 years, 6 months ago by binji
Modified:
6 years, 6 months ago
Reviewers:
noelallen1, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add bionic SDK bundle auto-updating to update_nacl_manifest BUG=none R=noelallen@chromium.org, sbc@chromium.org TEST=udpate_nacl_manifest_test.py TestUpdateManifest.testUpdateBionic Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -26 lines) Patch
M native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 17 chunks +62 lines, -20 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 6 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
binji
6 years, 6 months ago (2014-06-18 18:41:34 UTC) #1
noelallen1
lgtm
6 years, 6 months ago (2014-06-18 20:26:56 UTC) #2
binji
6 years, 6 months ago (2014-06-18 20:56:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r278170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698