Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 343673003: Ignore current command line in ProfileSyncServiceTest. (Closed)

Created:
6 years, 6 months ago by maniscalco
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, pshenoy
Project:
chromium
Visibility:
Public.

Description

Ignore current command line in ProfileSyncServiceTest. BUG=386207 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278341

Patch Set 1 #

Patch Set 2 : Ignore default value, just see that it can be overridden with flag. #

Patch Set 3 : Rebase. #

Patch Set 4 : Now compiles on Windows. #

Patch Set 5 : Use FILE_PATH_LITERAL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 3 4 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
maniscalco
Tim, would you please review this change?
6 years, 6 months ago (2014-06-18 17:25:28 UTC) #1
tim (not reviewing)
LGTM since this test seems better scoped anyway, but I don't fully understand why the ...
6 years, 6 months ago (2014-06-18 20:08:19 UTC) #2
maniscalco
On 2014/06/18 20:08:19, timsteele wrote: > LGTM since this test seems better scoped anyway, but ...
6 years, 6 months ago (2014-06-18 20:18:23 UTC) #3
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 6 months ago (2014-06-18 20:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/343673003/40001
6 years, 6 months ago (2014-06-18 20:20:27 UTC) #5
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 6 months ago (2014-06-18 23:38:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/343673003/60001
6 years, 6 months ago (2014-06-18 23:42:39 UTC) #7
maniscalco
The CQ bit was unchecked by maniscalco@chromium.org
6 years, 6 months ago (2014-06-19 00:27:40 UTC) #8
maniscalco
The CQ bit was checked by maniscalco@chromium.org
6 years, 6 months ago (2014-06-19 00:28:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/343673003/80001
6 years, 6 months ago (2014-06-19 00:31:00 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:11:20 UTC) #11
Message was sent while issue was closed.
Change committed as 278341

Powered by Google App Engine
This is Rietveld 408576698