Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 343663004: Floats following inlines break to next line unncessarily (Closed)

Created:
5 years ago by rhogan
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Floats following inlines break to next line unncessarily Don't include trailing space in linewidth calculations when deciding if a float can fit on a line. Merge http://trac.webkit.org/changeset/148622 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177135

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Patch Set 4 : Updated #

Patch Set 5 : Convert Tests to Ref Tests #

Total comments: 1

Patch Set 6 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -20 lines) Patch
A LayoutTests/css2.1/20110323/floats-001.html View 1 chunk +39 lines, -0 lines 0 comments Download
A + LayoutTests/css2.1/20110323/floats-001-expected.html View 1 chunk +8 lines, -5 lines 0 comments Download
A LayoutTests/css2.1/20110323/floats-102.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/css2.1/20110323/floats-102-expected.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-both-whitespace.html View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-both-whitespace-expected.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-leading-whitespace.html View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-leading-whitespace-expected.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-no-whitespace.html View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-no-whitespace-expected.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-trailing-whitespace.html View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/float-trailing-whitespace-expected.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/multiple-floats-with-whitespace.html View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/fast/inline-block/multiple-floats-with-whitespace-expected.html View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 1 2 3 4 5 4 chunks +22 lines, -12 lines 0 comments Download
M Source/core/rendering/line/LineWidth.h View 1 2 3 4 5 4 chunks +8 lines, -0 lines 0 comments Download
M Source/core/rendering/line/LineWidth.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rhogan
This is a WebKit line-layout patch I meant to merge a long time ago. There's ...
4 years, 12 months ago (2014-06-24 19:33:58 UTC) #1
leviw_travelin_and_unemployed
Close with a couple nits. https://codereview.chromium.org/343663004/diff/80001/Source/core/rendering/line/LineWidth.h File Source/core/rendering/line/LineWidth.h (right): https://codereview.chromium.org/343663004/diff/80001/Source/core/rendering/line/LineWidth.h#newcode50 Source/core/rendering/line/LineWidth.h:50: bool fitsOnLine(float extra, bool ...
4 years, 12 months ago (2014-06-24 20:07:46 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 11 months ago (2014-06-27 19:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/343663004/100001
4 years, 11 months ago (2014-06-27 19:03:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
4 years, 11 months ago (2014-06-27 19:52:32 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2014-06-27 20:56:53 UTC) #6
Message was sent while issue was closed.
Change committed as 177135

Powered by Google App Engine
This is Rietveld 408576698