Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 343663003: Revert "Enable Scroll Animation for RenderLayerScrollableArea" (Closed)

Created:
6 years, 6 months ago by weiliangc
Modified:
6 years, 6 months ago
Reviewers:
Ian Vollick
CC:
abarth-chromium, darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, danakj, dstockwell, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr., Rick Byers, rjwright, rune+blink, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert "Enable Scroll Animation for RenderLayerScrollableArea" This reverts commit 6fd2fdfc9696ee205daf9a43d07c49d30c246aad. Conflicts: LayoutTests/TestExpectations Source/core/page/PageAnimator.cpp Source/core/rendering/RenderLayerScrollableArea.cpp BUG=383946 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176446

Patch Set 1 #

Patch Set 2 : fix compile error in PageAnimator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -117 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/sub-frame-scroll.html View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 1 chunk +9 lines, -15 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ian Vollick
Lgtm
6 years, 6 months ago (2014-06-18 17:18:09 UTC) #1
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 6 months ago (2014-06-18 17:20:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/343663003/20001
6 years, 6 months ago (2014-06-18 17:20:40 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 19:42:58 UTC) #4
Message was sent while issue was closed.
Change committed as 176446

Powered by Google App Engine
This is Rietveld 408576698