Issue 343653005: Fix IAccessible2 interface in views accessibility.

Issue 343653005: Fix IAccessible2 interface in views accessibility. (Closed)

Created:
6 years, 6 months ago by dmazzoni

Modified:
6 years, 6 months ago

Reviewers:
David Tseng

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@nvda_fix_2

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix IAccessible2 interface in views accessibility. This was accidentally broken in r270074 when I added support for the IAccessible2_2 interface; I got the confusing COM_INTERFACE_ENTRY syntax subtly wrong. BUG=386374 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278528

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix all COM_INTERFACE macros #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	content/browser/accessibility/browser_accessibility_win.h	View	1	1 chunk	+4 lines, -4 lines	1 comment	Download
	M	ui/views/accessibility/native_view_accessibility_win.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

David Tseng

lgtm https://codereview.chromium.org/343653005/diff/1/ui/views/accessibility/native_view_accessibility_win.h File ui/views/accessibility/native_view_accessibility_win.h (right): https://codereview.chromium.org/343653005/diff/1/ui/views/accessibility/native_view_accessibility_win.h#newcode53 ui/views/accessibility/native_view_accessibility_win.h:53: COM_INTERFACE_ENTRY2(IAccessible2, IAccessible2_2) Just curious, why are you using ...

6 years, 6 months ago (2014-06-18 22:58:21 UTC) #2

dmazzoni

Oh, you're right. I guess we don't need it for anything other than IDispatch. All ...

6 years, 6 months ago (2014-06-19 06:36:34 UTC) #3

David Tseng

lgtm https://codereview.chromium.org/343653005/diff/20001/content/browser/accessibility/browser_accessibility_win.h File content/browser/accessibility/browser_accessibility_win.h (left): https://codereview.chromium.org/343653005/diff/20001/content/browser/accessibility/browser_accessibility_win.h#oldcode66 content/browser/accessibility/browser_accessibility_win.h:66: COM_INTERFACE_ENTRY(IAccessibleApplication) Not sure it tmatters now, but the ...

6 years, 6 months ago (2014-06-19 16:59:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/343653005/20001

6 years, 6 months ago (2014-06-19 18:45:03 UTC) #7

Message was sent while issue was closed.

Change committed as 278528

Expand Messages | Collapse Messages