Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/android/most_visited_sites.cc

Issue 343643002: [Android NTP] Use UMA histograms instead of local ones. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/most_visited_sites.cc
diff --git a/chrome/browser/android/most_visited_sites.cc b/chrome/browser/android/most_visited_sites.cc
index 07854b8d0fd55881fb04fb81f6ab9e6c81b68259..5eda3f36fa71b09f5ec6c82af16507cb240cd7d6 100644
--- a/chrome/browser/android/most_visited_sites.cc
+++ b/chrome/browser/android/most_visited_sites.cc
@@ -278,7 +278,7 @@ void MostVisitedSites::RecordOpenedMostVisitedItem(JNIEnv* env,
jint index) {
switch (mv_source_) {
case TOP_SITES: {
- HISTOGRAM_SPARSE_SLOWLY(kOpenedItemClientHistogramName, index);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kOpenedItemClientHistogramName, index);
break;
}
case SUGGESTIONS_SERVICE: {
@@ -289,7 +289,7 @@ void MostVisitedSites::RecordOpenedMostVisitedItem(JNIEnv* env,
server_suggestions_.suggestions(index).providers(0));
LogHistogramEvent(histogram, index, num_sites_);
} else {
- HISTOGRAM_SPARSE_SLOWLY(kOpenedItemServerHistogramName, index);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kOpenedItemServerHistogramName, index);
}
}
break;
@@ -353,9 +353,9 @@ void MostVisitedSites::OnMostVisitedURLsAvailable(
mv_source_ = TOP_SITES;
int num_tiles = urls.size();
- HISTOGRAM_SPARSE_SLOWLY(kNumTilesHistogramName, num_tiles);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kNumTilesHistogramName, num_tiles);
for (int i = 0; i < num_tiles; ++i) {
- HISTOGRAM_SPARSE_SLOWLY(kImpressionClientHistogramName, i);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kImpressionClientHistogramName, i);
}
JNIEnv* env = AttachCurrentThread();
@@ -389,10 +389,10 @@ void MostVisitedSites::OnSuggestionsProfileAvailable(
kImpressionServerHistogramFormat, suggestion.providers(0));
LogHistogramEvent(histogram, i, num_sites_);
} else {
- HISTOGRAM_SPARSE_SLOWLY(kImpressionServerHistogramName, i);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kImpressionServerHistogramName, i);
}
}
- HISTOGRAM_SPARSE_SLOWLY(kNumTilesHistogramName, i);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kNumTilesHistogramName, i);
mv_source_ = SUGGESTIONS_SERVICE;
// Keep a copy of the suggestions for eventual logging.
@@ -454,12 +454,12 @@ void MostVisitedSites::OnSuggestionsThumbnailAvailable(
}
void MostVisitedSites::RecordUMAMetrics() {
- HISTOGRAM_SPARSE_SLOWLY(kNumLocalThumbnailTilesHistogramName,
- num_local_thumbs_);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kNumLocalThumbnailTilesHistogramName,
+ num_local_thumbs_);
num_local_thumbs_ = 0;
- HISTOGRAM_SPARSE_SLOWLY(kNumEmptyTilesHistogramName, num_empty_thumbs_);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kNumEmptyTilesHistogramName, num_empty_thumbs_);
num_empty_thumbs_ = 0;
- HISTOGRAM_SPARSE_SLOWLY(kNumServerTilesHistogramName, num_server_thumbs_);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kNumServerTilesHistogramName, num_server_thumbs_);
num_server_thumbs_ = 0;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698