Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 343633002: telemetry: Fix key_silk_cases page whose content was offscreen (Closed)

Created:
6 years, 6 months ago by ajuma
Modified:
6 years, 6 months ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

telemetry: Fix key_silk_cases page whose content was offscreen This fixes a key_silk_cases page whose content was moved offscreen on phone-sized Android devices by the addition of a viewport tag (for triggering GPU rasterization), causing the smoothness benchmark to fail on these devices. BUG=381368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278272

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/perf/page_sets/data/key_silk_cases.json View 2 chunks +5 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/key_silk_cases_015.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ajuma
The page was using "right: 400px" to position content, but the viewport tag makes the ...
6 years, 6 months ago (2014-06-18 15:30:43 UTC) #1
ernstm
On 2014/06/18 15:30:43, ajuma wrote: > The page was using "right: 400px" to position content, ...
6 years, 6 months ago (2014-06-19 02:01:21 UTC) #2
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 6 months ago (2014-06-19 02:01:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/343633002/20001
6 years, 6 months ago (2014-06-19 02:03:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:31:09 UTC) #5
Message was sent while issue was closed.
Change committed as 278272

Powered by Google App Engine
This is Rietveld 408576698