pkg/unittest/lib/test_controller.js - Issue 34363005: Filtering MutationObserver polyfill messages from test_controller logging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/test_controller.js

Issue 34363005: Filtering MutationObserver polyfill messages from test_controller logging (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/lib/test_controller.js

diff --git a/pkg/unittest/lib/test_controller.js b/pkg/unittest/lib/test_controller.js

index 68b83bfe0a33f260a8ec4bcc9285d8c2b7868975..efdf2b441c8b5461afc4aeb296cbdb0a4ba9aca4 100644

--- a/pkg/unittest/lib/test_controller.js

+++ b/pkg/unittest/lib/test_controller.js

@@ -91,7 +91,12 @@ function notifyDone() {

function processMessage(msg) {

// TODO(ricow): REMOVE, debug info, see issue 13292

if (!testRunner) {

- printMessage('processMessage(): ' + msg);

+ try {

+ // Filter out ShadowDOM polyfill messages which are random floats.

+ if (msg != parseFloat(msg)) {

+ printMessage('processMessage(): ' + msg);

+ }

+ } catch(e) {}

}

if (typeof msg != 'string') return;

Jennifer Messerly 2013/10/23 18:14:32 maybe just move up this check instead?

blois 2013/10/23 18:20:23 Done, removed try/catch.

if (msg == 'unittest-suite-done') {

« no previous file with comments | « no previous file | no next file » | no next file with comments »