Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

Issue 343613004: Move needsPreviewElement to TimelineUIUtilsImple and make it private (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TimelineUIUtilsImpl = function() 9 WebInspector.TimelineUIUtilsImpl = function()
10 { 10 {
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 { 259 {
260 if (record.stackTrace()) 260 if (record.stackTrace())
261 return linkifyCallFrame(record.stackTrace()[0]); 261 return linkifyCallFrame(record.stackTrace()[0]);
262 if (record.callSiteStackTrace()) 262 if (record.callSiteStackTrace())
263 return linkifyCallFrame(record.callSiteStackTrace()[0]); 263 return linkifyCallFrame(record.callSiteStackTrace()[0]);
264 return null; 264 return null;
265 } 265 }
266 } 266 }
267 267
268 /** 268 /**
269 * @param {string=} recordType
270 * @return {boolean}
271 */
272 WebInspector.TimelineUIUtilsImpl._needsPreviewElement = function(recordType)
273 {
274 if (!recordType)
275 return false;
276 const recordTypes = WebInspector.TimelineModel.RecordType;
277 switch (recordType) {
278 case recordTypes.ResourceSendRequest:
279 case recordTypes.ResourceReceiveResponse:
280 case recordTypes.ResourceReceivedData:
281 case recordTypes.ResourceFinish:
282 return true;
283 default:
284 return false;
285 }
286 }
287
288 /**
269 * @param {!WebInspector.TimelineModel.Record} record 289 * @param {!WebInspector.TimelineModel.Record} record
270 * @param {!WebInspector.TimelineModel} model 290 * @param {!WebInspector.TimelineModel} model
271 * @param {!WebInspector.Linkifier} linkifier 291 * @param {!WebInspector.Linkifier} linkifier
272 * @param {function(!DocumentFragment)} callback 292 * @param {function(!DocumentFragment)} callback
273 * @param {boolean} loadedFromFile 293 * @param {boolean} loadedFromFile
274 */ 294 */
275 WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model , linkifier, callback, loadedFromFile) 295 WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model , linkifier, callback, loadedFromFile)
276 { 296 {
277 var imageElement = /** @type {?Element} */ (record.getUserObject("TimelineUI Utils::preview-element") || null); 297 var imageElement = /** @type {?Element} */ (record.getUserObject("TimelineUI Utils::preview-element") || null);
278 var relatedNode = null; 298 var relatedNode = null;
279 var recordData = record.data(); 299 var recordData = record.data();
280 var barrier = new CallbackBarrier(); 300 var barrier = new CallbackBarrier();
281 if (!imageElement && WebInspector.TimelineUIUtils.needsPreviewElement(record .type())) 301 if (!imageElement && WebInspector.TimelineUIUtilsImpl._needsPreviewElement(r ecord.type()))
282 WebInspector.DOMPresentationUtils.buildImagePreviewContents(record.targe t(), recordData["url"], false, barrier.createCallback(saveImage)); 302 WebInspector.DOMPresentationUtils.buildImagePreviewContents(record.targe t(), recordData["url"], false, barrier.createCallback(saveImage));
283 if (recordData["backendNodeId"]) 303 if (recordData["backendNodeId"])
284 record.target().domModel.pushNodesByBackendIdsToFrontend([recordData["ba ckendNodeId"]], barrier.createCallback(setRelatedNode)); 304 record.target().domModel.pushNodesByBackendIdsToFrontend([recordData["ba ckendNodeId"]], barrier.createCallback(setRelatedNode));
285 barrier.callWhenDone(callbackWrapper); 305 barrier.callWhenDone(callbackWrapper);
286 306
287 /** 307 /**
288 * @param {!Element=} element 308 * @param {!Element=} element
289 */ 309 */
290 function saveImage(element) 310 function saveImage(element)
291 { 311 {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 else if (recordType === recordTypes.TimeStamp) 513 else if (recordType === recordTypes.TimeStamp)
494 eventDivider.className += " resources-orange-divider"; 514 eventDivider.className += " resources-orange-divider";
495 else if (recordType === recordTypes.BeginFrame) 515 else if (recordType === recordTypes.BeginFrame)
496 eventDivider.className += " timeline-frame-divider"; 516 eventDivider.className += " timeline-frame-divider";
497 517
498 if (title) 518 if (title)
499 eventDivider.title = title; 519 eventDivider.title = title;
500 520
501 return eventDivider; 521 return eventDivider;
502 } 522 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698