Issue 343613004: Move needsPreviewElement to TimelineUIUtilsImple and make it private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343613004: Move needsPreviewElement to TimelineUIUtilsImple and make it private (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move needsPreviewElement to TimelineUIUtilsImple and make it private Drive-by: removed formatter for counters field which is not in the protocol anymore. BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176495

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -22 lines)			Patch
M	LayoutTests/http/tests/inspector/timeline-test.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js	View	2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 6 months ago (2014-06-19 07:31:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r176495 (presubmit successful).

Expand Messages | Collapse Messages