Report when blacklist.cc fails to setup the blacklisting thunk.

Report when blacklist.cc fails to setup the blacklisting thunk.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278393

[csharp, 2014-06-18 15:37:54]

I tested this locally to ensure it would record the right UMA stat, but there
doesn't seem to be a nice way to test it in unit tests.

[krstnmnlsn, 2014-06-18 18:36:41]

https://codereview.chromium.org/343613003/diff/20001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_win.cc (right):

https://codereview.chromium.org/343613003/diff/20001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_win.cc:152: // initialized is if the thunk setup
failed. See blacklist.cc
I guess my comment on line 196 of blacklist.cc is slightly incorrect (and seems
to disagree with this comment), should we change it to something like "Reaching
this point with the setup running state means the setup code <did not crash>"?

[csharp, 2014-06-18 19:03:00]

https://codereview.chromium.org/343613003/diff/20001/chrome/browser/chrome_el...
File chrome/browser/chrome_elf_init_win.cc (right):

https://codereview.chromium.org/343613003/diff/20001/chrome/browser/chrome_el...
chrome/browser/chrome_elf_init_win.cc:152: // initialized is if the thunk setup
failed. See blacklist.cc
On 2014/06/18 18:36:41, krstnmnlsn wrote:
> I guess my comment on line 196 of blacklist.cc is slightly incorrect (and
seems
> to disagree with this comment), should we change it to something like
"Reaching
> this point with the setup running state means the setup code <did not crash>"?

Correct, I updated blacklist.cc

[krstnmnlsn, 2014-06-18 19:14:47]

lgtm

[csharp, 2014-06-18 19:26:40]

Robert, can you review (and then lgtm) this as a committer, thanks

[robertshield, 2014-06-18 21:49:25]

lgtm

[commit-bot: I haz the power, 2014-06-18 21:50:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/csharp@chromium.org/343613003/40001

[commit-bot: I haz the power, 2014-06-19 08:25:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 08:25:36]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[csharp, 2014-06-19 13:20:18]

The CQ bit was checked by csharp@chromium.org

[commit-bot: I haz the power, 2014-06-19 13:21:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/csharp@chromium.org/343613003/40001

[commit-bot: I haz the power, 2014-06-19 16:17:09]

Change committed as 278393